Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prompt user to login if not logged in when receiving wallet connect request #2704

Merged
merged 3 commits into from
Jul 4, 2024
Merged

feat: prompt user to login if not logged in when receiving wallet connect request #2704

merged 3 commits into from
Jul 4, 2024

Conversation

MarkNerdi
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi MarkNerdi requested a review from jeeanribeiro July 2, 2024 11:41
@MarkNerdi MarkNerdi self-assigned this Jul 2, 2024
@MarkNerdi MarkNerdi linked an issue Jul 2, 2024 that may be closed by this pull request
️🛠 - Prompt user to login if not logged in when receiving wallet connect request #2615
Closed
@jeeanribeiro jeeanribeiro enabled auto-merge (squash) July 4, 2024 04:24
@jeeanribeiro jeeanribeiro merged commit b8bbe50 into develop Jul 4, 2024
7 checks passed
@jeeanribeiro jeeanribeiro deleted the 2615----prompt-user-to-login-if-not-logged-in-when-receiving-wallet-connect-request branch July 4, 2024 04:27
jeeanribeiro pushed a commit that referenced this pull request Jul 5, 2024
@MarkNerdi @jeeanribeiro
feat: prompt user to login if not logged in when receiving wallet con…
a1f3d79 
…nect request (#2704)

* cache sessionrequest

* only handle request if logged in to same account
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeeanribeiro jeeanribeiro jeeanribeiro approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100 cvarley100 is a code owner

@nicole-obrien nicole-obrien Awaiting requested review from nicole-obrien nicole-obrien is a code owner

Assignees

@MarkNerdi MarkNerdi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

️🛠 - Prompt user to login if not logged in when receiving wallet connect request
2 participants
@MarkNerdi @jeeanribeiro